[PATCH] m68k: amiga - GVP Series II SCSI zorro_driver conversion (was: Re: [PATCH] m68k: amiga - A2091/A590 SCSI zorro_driver conversion (was: Re: [PATCH/RFC 0/16] m68k: Device model patches))

From: Geert Uytterhoeven
Date: Wed May 13 2009 - 16:05:48 EST


On Tue, May 12, 2009 at 22:30, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Tue, May 5, 2009 at 09:36, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>> On Sat, Apr 18, 2009 at 20:52, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>>> [07] m68k: amiga - A3000 SCSI platform device conversion
>>>
>>> Due to lack of hardware (only Amiga 4000 here), I couldn't test all drivers.
>>> Especially the SCSI drivers could use some testing feedback.
>>> The changes to most other drivers are fairly trivial.
>>
>> I'm a bit reluctant to apply the A3000 SCSI platform device conversion without
>> having received any feedback, and I would like to apply the whole series ASAP.
>> Did anyone try on A3000/A3000T? Similar changes are needed to convert the
>> A2091 and GVP II SCSI drivers to the zorro_driver model, so if we have
>> more users
>> of those, I can do that conversion first, so it can receive some testing.
>
> Here's the conversion of the A2091/A590 SCSI driver to a proper zorro_driver.
> Due to the lack of hardware, it's untested.
>
> BTW, when comparing a2091.c to a3000.c, a3000.c has several additional mb()s
> and one additiona barrier(). Do we need those in a2091.c, too?

And here's his brother for the GVP Series II SCSI driver. Same comments...

(Yes, I'm gonna split these patches to make it more obvious that the
other cleanups
are correct).