Re: [PATCH] usb-serial: ftdi: don't dereference NULL pointer

From: Daniel Mack
Date: Wed May 13 2009 - 10:42:23 EST


On Wed, May 13, 2009 at 07:35:36AM -0700, Greg KH wrote:
> On Wed, May 13, 2009 at 01:21:43PM +0200, Daniel Mack wrote:
> > The FTDI USB serial driver dereferences its priv structure in
> > ftdi_close() without checking for NULL pointer conditions, see the Oops
> > attached.
>
> Hm, I think this was already resolved with Alan's patch that went in
> right after 2.6.30-rc5 came out.

That was a similiar issue, yes. But it occured under different
circumstances, not under the condition I described.

> Can you check Linus's current tree to
> see if we still need this patch or not?

Is is needed, yes. I'm working on Linus' git as of this morning, so I'm
cutting edge mainline and can still perfectly reproduce the problem.

Not anymore with my patch, though.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/