Re: [tip:irq/numa] x86: read apic ID in the !acpi_lapic case

[Cyrill Gorcunov]

[Ingo Molnar - Tue, May 12, 2009 at 01:22:05PM +0200]
| 
| this build bug is still unfixed:
| 
| drivers/pci/hotplug/ibmphp_core.c:165: error: expected identifier before â&â token
| drivers/pci/hotplug/ibmphp_core.c:166: error: too few arguments to function âIO_APIC_get_PCI_irq_vectorâ
| 
| 	Ingo
| 

Grrr... this line looks really suspicious inideed

			for (i = 0; i < 4; i++)
				(*cur_slot)->irq[i] = IO_APIC_get_PCI_irq_vector((int) (*cur_slot)->bus,
--->						(int) (*cur_slot)->device, i.
						&ioapic, &ioapic_pin,
						&triggering, &polarity);

but it's _not_ 'cause of this commit, since
we didn't even touch this file :) The point
symbol should be changed to comma. Just a
misprint I believe. Appened patch should do
the trick.

	-- Cyrill
---
From: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
Subject: [PATCH] pci: ibmphp_core.c - fix misprint in ibmphp_init_devno

Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
CC: Yinghai Lu <yinghai@xxxxxxxxxx>
---
 drivers/pci/hotplug/ibmphp_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.git/drivers/pci/hotplug/ibmphp_core.c
=====================================================================
--- linux-2.6.git.orig/drivers/pci/hotplug/ibmphp_core.c
+++ linux-2.6.git/drivers/pci/hotplug/ibmphp_core.c
@@ -161,7 +161,7 @@ int ibmphp_init_devno(struct slot **cur_
 			(*cur_slot)->device = PCI_SLOT(rtable->slots[loop].devfn);
 			for (i = 0; i < 4; i++)
 				(*cur_slot)->irq[i] = IO_APIC_get_PCI_irq_vector((int) (*cur_slot)->bus,
-						(int) (*cur_slot)->device, i.
+						(int) (*cur_slot)->device, i,
 						&ioapic, &ioapic_pin,
 						&triggering, &polarity);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/