Re: [patch 2/2] spufs: remove double check for non-negative dentry

[Arnd Bergmann]

On Tuesday 05 May 2009, jblunck@xxxxxxx wrote:
> This patch removes an unnecessary double check if the dentry returned by
> lookup_create() is actually non-negative. Since lookup_create() itself returns
> an error in this case just remove the check.
> 
> Signed-off-by: Jan Blunck <jblunck@xxxxxxx>

Looks good, I'll push this one on, unless Jeremy has objections.

Thanks,

	Arnd <><

> --- a/arch/powerpc/platforms/cell/spufs/inode.c
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> @@ -625,10 +625,6 @@ long spufs_create(struct nameidata *nd,
>  	if (IS_ERR(dentry))
>  		goto out_dir;
>  
> -	ret = -EEXIST;
> -	if (dentry->d_inode)
> -		goto out_dput;
> -
>  	mode &= ~current->fs->umask;
>  
>  	if (flags & SPU_CREATE_GANG)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/