Re: [PATCH v2] x86: fix ktermios-termio conversion

From: Alan Cox
Date: Tue May 12 2009 - 06:06:12 EST


> My argument was very simple: the patch causes +150 bytes of bloat.
> The try/ex/catch method can help reduce register pressure and can
> reducethe size of code quite visibly.

My argument is even simpler - its not worth the effort in the first place.

I'm sure you could use the same time to shave 150 bytes and a few clocks
of a path that actually gets executed.

Arnd - can you send me a diff that keeps the existing horrible macro
version, the existing __put_user usage and just fixes c_line ? It's
worked for 15 years, its not worth the time being fancy with it.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/