Re: [PATCH] ioatdma: fix "ioatdma frees DMA memory with wrong function"

From: Alexander Beregalov
Date: Tue May 12 2009 - 06:03:41 EST


2009/4/23 Maciej Sosnowski <maciej.sosnowski@xxxxxxxxx>:
> as reported by Alexander Beregalov <a.beregalov@xxxxxxxxx>
>
> ioatdma 0000:00:08.0: DMA-API: device driver frees DMA memory with
> wrong function [device address=0x000000007f76f800] [size=2000 bytes]
> [map
> ped as single] [unmapped as page]
>
> The ioatdma driver was unmapping all regions
> (either allocated as page or single) using unmap_page.
> This patch lets dma driver recognize if unmap_single or unmap_page should be used.
> It introduces two new dma control flags:
> DMA_COMPL_SRC_UNMAP_SINGLE and DMA_COMPL_DEST_UNMAP_SINGLE.
> They should be set to indicate dma driver to do dma-unmapping as single
> (first one for the source, tha latter for the destination).
> If respective flag is not set, the driver assumes dma-unmapping as page.
>
> Signed-off-by: Maciej Sosnowski <maciej.sosnowski@xxxxxxxxx>
> Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Reported-by: Alexander Beregalov <a.beregalov@xxxxxxxxx>
> Tested-by: Alexander Beregalov <a.beregalov@xxxxxxxxx>
> ---

Will it be sent to Linus ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/