Re: [RFC v3][PATCH 2/2] intel_txt: Intel(R) TXT and tboot kernel support

From: Andi Kleen
Date: Tue May 12 2009 - 05:50:42 EST


> > > > + ((void(*)(void))(long)tboot_shared->shutdown_entry)();
>
> be better? Or is shutdown_entry always mapped into [0..2GB) on

0..4GB and this code runs in a identity mapping.

> 64-bit? Even then, not sign-extending RIP addresses is wrong and
> invites bugs/restrictions.

You never have to sign extend when going from 32bit to 64bit
on x86-64.

-andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/