Re: [v3][PATCH 5/5] Merge code for singleandmultiple-instancemounts

[H. Peter Anvin]

Serge E. Hallyn wrote:
> Quoting Sukadev Bhattiprolu (sukadev@xxxxxxxxxxxxxxxxxx):
> ...
>
> > >From 2f7746f4df78ff57125c4714f0cd64e739ccf804 Mon Sep 17 00:00:00 2001
> > From: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
> > Date: Mon, 11 May 2009 13:11:11 -0700
> > Subject: [PATCH] devpts: Correctly set default options
> >
> > devpts_get_sb() calls memset(0) to clear mount options and calls
> > parse_mount_options() if user specified any mount options. The memset(0) is
> > bogus since the 'mode' and 'ptmxmode' options are non-zero by default.
> > parse_mount_options() restores options to default anyway and can properly deal
> > with NULL mount options.
> >
> > So in devpts_get_sb() remove memset(0) and call parse_mount_options() even for
> > NULL mount options.
> >
> > Bug reported by Eric Paris: http://lkml.org/lkml/2009/5/7/448.
>
> Would you almost say... Reported-by: ?  :)
> > Signed-off-by: Sukadev Bhattiprolu (sukadev@xxxxxxxxxx)
>
> Looks good.
>
> Acked-by: Serge Hallyn <serue@xxxxxxxxxx>

Reviewed-by: H. Peter Anvin <hpa@xxxxxxxxx>

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/