Re: [patch 06/11 -mmotm] oom: move oom_adj value from task_structto mm_struct

From: Andrew Morton
Date: Mon May 11 2009 - 17:26:39 EST


On Mon, 11 May 2009 01:43:10 -0700 (PDT)
David Rientjes <rientjes@xxxxxxxxxx> wrote:

> On Mon, 11 May 2009, KOSAKI Motohiro wrote:
>
> > From technical view, your explanation seems good although I haven't
> > review your patch.
> > but this patch break staging driver rule. I don't like it.
> >
> > IOW, if greg pull this patch into his staging tree, it might make
> > patch conflict against -mm tree in nearly future.
> >
>
> If I am going to break code that is in mainline (like the Android low
> memory killer is) by moving a member of a data structure, then I'd like to
> provide a fix for it so that it works after my change. I'll leave the
> merging to Andrew and Greg and if they'd prefer I do this patch in two
> parts, that's fine by me as long as they merge them at the same time. I
> thought since this code is mainline that it would be easier to go through
> in one series.

Yep, this all has to be done as a single commit to avoid creating
points in the commit sequence where the kernel doesn't build.

As I'm cherrypicking my way around the android driver changes I
reworked this patch to apply on plain old mainline.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/