Re: [PATCH 1/4] kernel: constructor support

[Sam Ravnborg]

On Mon, May 11, 2009 at 10:43:34AM +0200, Peter Oberparleiter wrote:
> Américo Wang wrote:
> >On Fri, May 08, 2009 at 05:44:09PM +0200, Peter Oberparleiter wrote:
> >>From: Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>
> >>Index: linux-2.6.30-rc4/init/main.c
> >>===================================================================
> >>--- linux-2.6.30-rc4.orig/init/main.c
> >>+++ linux-2.6.30-rc4/init/main.c
> >>@@ -700,6 +700,18 @@ asmlinkage void __init start_kernel(void
> >>	rest_init();
> >>}
> >>
> >>+/* Call all constructor functions linked into the kernel. */
> >>+static void __init do_ctors(void)
> >>+{
> >>+#ifdef CONFIG_CONSTRUCTORS
> >>+	extern ctor_fn_t __ctors_start[], __ctors_end[];
> >
> >
> >I would like these to be globally decleared, since they are.
> 
> Ok, I will move the __ctors_* declarations to include/linux/ínit.h

include/asm-generic/sections.h please.
And please add a comment too.

That the other entries in the same file lacks a comment is not
the example to follow.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/