Re: [tip:x86/xen] x86: use flush_tlb_others to implementflush_tlb_all, fix

From: Ingo Molnar
Date: Mon May 11 2009 - 11:42:33 EST



* Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> wrote:

> in any case I would guess that the fix is:
>
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -87,6 +87,7 @@
> #include <asm/cacheflush.h>
> #include <asm/processor.h>
> #include <asm/bugs.h>
> +#include <asm/tlbflush.h>
>
> #include <asm/system.h>
> #include <asm/vsyscall.h>

Guessing is not enough - please review the prototype position. Is it
available on all configs? It is not ...

But even the proper fix runs into that smp_processor_id() bug i just
posted.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/