Re: [tip:perfcounters/core] perf_counter, x86: removeX86_FEATURE_ARCH_PERFMON flag for AMD cpus

[Jaswinder Singh Rajput]

Hello Robert,

On Mon, 2009-05-11 at 14:39 +0200, Robert Richter wrote:
> On 11.05.09 17:43:44, Jaswinder Singh Rajput wrote:
> > On Sun, 2009-05-10 at 08:30 +0200, Ingo Molnar wrote:
> > > * Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:
> > > 
> > > > > #define X86_FEATURE_ARCH_PERFMON (3*32+11) /* Intel Architectural PerfMon */
> > > > > should be replaced by
> > > > > #define X86_FEATURE_ARCH_PERFMON (3*32+11) /* Performace Monitor */
> > > > > 
> > > > > All x86 cpus which support performance monitor should set this feature.
> > > > > 
> > > > 
> > > > Currently X86_FEATURE_ARCH_PERFMON is enabled for >= Intel Core2
> > > > 
> > > > But Performance monitor is almost supported by all Intel 
> > > > processors. I am adding few MSRs list for reference to see 
> > > > complete list please check arch/x86/kernel/cpu/cpu_debug.c
> > > 
> > > I think you are confusing two things:
> > > 
> > > - The 'architectural perfmon' CPU flag, enumerated in CPUID. (this 
> > >   is a relatively new CPUID flag that only Intel CPUs at around 
> > >   Core2 and later will report.)
> > > 
> > > - The concept of 'performance monitoring' - which has been present 
> > >   in various x86 CPUs starting at the original Pentium (P5) 15 years 
> > >   ago or so.
> > > 
> > 
> > Here is the patch for review for ancient performance monitoring
> > cpufeature, complete cpu_debug and cpu_feature patches are available
> > at :
> > http://git.kernel.org/?p=linux/kernel/git/jaswinder/linux-2.6-tip.git;a=summary
> > 
> > Subject: [PATCH] x86: Add cpufeature for ancient performance monitoring
> 
> Jaswinder,
> 
> which branch is this patch against? It is not tip/perfcounters/core
> nor tip/master.
> 

This patch was based on
http://git.kernel.org/?p=linux/kernel/git/jaswinder/linux-2.6-tip.git;a=summary
(git tree takes some time for update)

These patches are still for review and I will release these patches in
one or two days after adding some more patches.

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/