Re: [PATCH][REPOST] Don't export sched_mc_power_savings onmulti-socket single core system

[Ingo Molnar]

* Mahesh Jagannath Salgaonkar <mahesh@xxxxxxxxxxxxxxxxxx> wrote:

> My previous post got lost somewhere in lkml list. Hence reposting 
> this patch again.

no, it did not get lost, i gave you the feedback below more than a 
month ago. FYI, this resubmission has the same corrupted-patch 
problem.

	Ingo

----- Forwarded message from Ingo Molnar <mingo@xxxxxxx> -----

Date: Wed, 8 Apr 2009 13:42:03 +0200
From: Ingo Molnar <mingo@xxxxxxx>
To: Mahesh Jagannath Salgaonkar <mahesh@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Don't export sched_mc_power_savings on multi-socket
	single core system
Cc: Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>,
	Suresh B Siddha <suresh.b.siddha@xxxxxxxxx>,
	Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>,
	svaidy@xxxxxxxxxxxxxxxxxx, balbir@xxxxxxxxxxxxxxxxxx,
	dipankar@xxxxxxxxxx, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>


* Mahesh Jagannath Salgaonkar <mahesh@xxxxxxxxxxxxxxxxxx> wrote:

> Fix to prevent sched_mc_power_saving from being exported through 
> sysfs for multi-scoket single core system. Max cores should be 
> always greater than one (1). My earlier patch that introduced fix 
> for not exporting 'sched_mc_power_saving' on laptops broke it on 
> multi-socket single core system. This fix addresses issue on both 
> laptop and multi-socket single core system. Below are the Test 
> results:

> +#define mc_capable()   (boot_cpu_data.x86_max_cores > 1) && \
> +                       (cpumask_weight(cpu_core_mask(0)) != nr_cpu_ids)
> #define smt_capable()                  (smp_num_siblings > 1)

patch looks good but is whitespace damaged (all tabs were converted 
to spaces). See Documentation/email-clients.txt about how to set up 
your client.

	Ingo

----- End forwarded message -----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/