Re: Q. Switch open_exec() and sys_uselib() to do_open_filp()

[Al Viro]

On Mon, May 11, 2009 at 09:55:17AM +0900, hooanon05@xxxxxxxxxxx wrote:
> 
> By the commit 6e8341a11eb21826b7192d0bb88cb5b44900a9af
> "Switch open_exec() and sys_uselib() to do_open_filp()",
> FMODE_EXEC flag is passed to struct file. I have no objection nor
> question about that.
> 
> But it is set to file->f_flags instead of f_mode.
> Is this intended behaviour?

It is previously existing behaviour.  Check what path_lookup_open() does
and how had it used to be called.

And no, very little about intents makes any sense, including that part.
Call graph of the entire lookup-and-open-related machinery least of all.
So we have to untangle that mound of mating tapeworms, one by one ;-/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/