Re: [PATCH 1/1] DMA: mark DMA_nBITS_MASK as deprecated

[FUJITA Tomonori]

On Fri,  8 May 2009 10:00:38 +0200
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> Ingo Molnar <mingo@xxxxxxx> wrote:
> > Can you see a way to emit build warnings? If yes then that might be 
> > a better solution instead of breaking in-the-pipeline code.
> 
> What about this:
> --
> 
> Mark them deprecated so that 3rd party vendors get notified about that
> before their modules break by removing those macros later.
> 
> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> ---
>  include/linux/dma-mapping.h |   26 ++++++++++++++------------
>  1 files changed, 14 insertions(+), 12 deletions(-)

Ah, nice magic!

Well, "warning: 'DMA_DEPRECATED' is deprecated" warning message is a
bit obscure but the developers should notice that they do something
wrong.

Acked-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>


Thanks a lot,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/