Re: [PATCH 4/8] proc: export more page flags in /proc/kpageflags

[Wu Fengguang]

On Sat, May 09, 2009 at 01:59:14PM +0800, Ingo Molnar wrote:
> 
> * Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:
> 
> > > /proc/kpageflags should be done via the proper methods outlined 
> > > in the previous mails i wrote on this topic: for example by 
> > > using the 'object collections' abstraction i suggested. Clean 
> > > enumeration of all pages (files, tasks, etc.) and the definition 
> > > of histograms over it via free-form filter expressions is the 
> > > right way to do this. It would not only help other subsystems, 
> > > it would also be far more capable.
> > 
> > For the new interfaces(files etc.) I'd very like to use the ftrace 
> > interface. For the existing pagemap interfaces, if they can 
> > fulfill their targeted tasks, why bother making the shift?
> 
> Because they were a mistake to be merged? Because having them 
> fragments and thus weakens Linux instrumentation in general? 
> Because, somewhat hipocritically, other MM instrumentation patches 
> are being rejected under the pretense that they "do not matter" - 
> while instrumentation that provably _does_ matter (yours) is added 
> outside the existing instrumentation frameworks?
> 
> > When the pagemap interfaces cannot satisfy some new applications, 
> > and ftrace can provide a superset of the pagemap interfaces and 
> > shows clear advantages while meeting the new demands, then we can 
> > schedule tearing down of the old interface?
> 
> Yes. But meanwhile dont extend it ... otherwise this bad cycle will 
> never end. "Oh, we just added this to /proc/kpageflags too, why 
> should we go through the trouble of use the generic framework?"
> 
> Do you see my position?

Yes I can understand the merits of conforming to a generic framework.
But that alone is not enough. If you at the same time demonstrate some
clear technical advantages(flexibility, speed, simplicity etc.), then
it would be great.  (Let me work out some expectations for ftrace..)

Thanks,
Fengguang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/