Re: [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts

[Marc Dionne]

On 05/07/2009 07:21 PM, Sukadev Bhattiprolu wrote:
> Er. I meant add following lines after the memset().
>
> |         opts->mode    = DEVPTS_DEFAULT_MODE;
> |         opts->ptmxmode = DEVPTS_DEFAULT_PTMX_MODE;

Adding those two lines (with . instead of ->) does fix the issue for me, 
thanks.

| > Of course we would still need to understand if/
| > why this patch changes the settings.

That particular patch changed things because the original memcpy in 
new_pts_mount() did this:

memcpy(&fsi->mount_opts, opts, sizeof(opts));

where opts was a pointer, not a structure.  So only the first few bytes 
of the blank opts actually got copied over.  The patch moved this memcpy 
to devpts_get_sb() and in the process fixed the sizeof error.

Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/