Re: [PATCH 1/5] hrtimer: per-cpu cached values of ktime

From: Andrew Morton
Date: Fri May 08 2009 - 19:15:32 EST


On Fri, 08 May 2009 18:52:20 +0200
Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> --- linux-2.6.orig/include/linux/hrtimer.h
> +++ linux-2.6/include/linux/hrtimer.h
> @@ -173,8 +173,13 @@ struct hrtimer_cpu_base {
> int hres_active;
> unsigned long nr_events;
> #endif
> + ktime_t ktime_irq;
> + int ktime_irq_set;
> };

struct hrtimer_cpu_base has nice kerneldoc which (used to) describe
its fields.

Please please please always always always comment data structures. The
bang-for-your-comment-buck is higher than anywhere else.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/