Re: [PATCH] x86-64: improve e820_search_gap()

From: Andi Kleen
Date: Fri May 08 2009 - 16:49:06 EST


On Fri, May 08, 2009 at 01:15:38PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >"Jan Beulich" <jbeulich@xxxxxxxxxx> writes:
> >>Why blindly? Aren't hotpluggable memory ranges supposed to be reserved
> >>in the E820 map?
> >
> >They are supposed to be reserved in SRAT, but not in e820.
>
> Ah, okay. Perhaps we should fold this information into our internal
> "e820" map? If so I guess the question is how soon we can do that.

You could do that or just query SRAT too, but ...

The problem is really that there are still systems which have hidden
holes which are not reserved anywhere. When I last hacked on the gap algorithm
it triggered subtle bugs. So this will never be fully reliable.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/