Re: [PATCH 01/14] x86, boot: align the .bss section in thedecompressor

From: Cyrill Gorcunov
Date: Fri May 08 2009 - 13:16:21 EST


[H. Peter Anvin - Fri, May 08, 2009 at 10:03:34AM -0700]
| Cyrill Gorcunov wrote:
| > |
| > | diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
| > | index 0d26c92..27c168d 100644
| > | --- a/arch/x86/boot/compressed/vmlinux.lds.S
| > | +++ b/arch/x86/boot/compressed/vmlinux.lds.S
| > | @@ -42,6 +42,7 @@ SECTIONS
| > | *(.data.*)
| > | _edata = . ;
| > | }
| > | + . = ALIGN(32);
| > | .bss : {
| > | _bss = . ;
| > | *(.bss)
| > | --
| > | 1.6.0.6
| > |
| >
| > Hi Peter, should not it be ALIGN(8) rather? I thought
| > we keep these sections as tight as possible in a sake
| > of limitation of setup code size. Perhaps I miss something.
| >
|
| This isn't the setup code at all. This is the actual kernel, although
| in its compressed form. Furthermore, this is the bss, so it doesn't
| affect the compressed image size.
|
| -hpa
|

yeah, unfortunately I reveal that when my mail already gone.
though I don't understand why 32 is there... could you please?

-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/