Re: [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts

[Peter Staubach]

Sukadev Bhattiprolu wrote:
> | Must be the
> | 
> | 	memset(&opts, 0, sizeof(opts));
> | 
> | in devpts_get_sb() (first statement). It should probably set the options to
> | default values for cases where 'data' is NULL.
> | 
> | For now, can you try replacing the memset with:
>
> Er. I meant add following lines after the memset().
>
> |         opts->mode    = DEVPTS_DEFAULT_MODE;
> |         opts->ptmxmode = DEVPTS_DEFAULT_PTMX_MODE;
> | 
> | Sukadev

With the obvious syntactic changes to account for opts being a
struct as opposed to being a pointer to a struct, these two lines
do seem to make things better.

       ps
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/