Re: [PATCH] x86: Reduce the default HZ value

From: Alan Cox
Date: Thu May 07 2009 - 13:11:22 EST


On Thu, 07 May 2009 12:55:05 -0400
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> H. Peter Anvin wrote:
> > Alan Cox wrote:
> >> Hooray - finally someone admits the *real* problem here, and for power
> >> management too. Otherwise known as "referencing jiffies as a variable must
> >> die"
> >
> > Amen. Also, "using HZ as a unit of measurement must die, too."
>
> Love to -- now, what will it be replaced with?
>
> grep for 'deadline' in drivers/ata/libata* to find an example not so
> easily converted away from jiffies.

I don't see any.

I do see a complicated interface that appears to actually really want to
implement

add_timer(&foo->expiry_timer);

and checks against the timer completing. In fact it looks as if all the
stuff in there is really down to

add a timer
check if it expired
check how long until it expires
delete it

And you might as well measure that in HZ=1000's better known as
"milliseconds"

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/