Re: [PATCH 7/7] x86/pci: update pirq_enable_irq to setup io apicrouting -v2

From: Jesse Barnes
Date: Thu May 07 2009 - 12:55:29 EST


On Thu, 7 May 2009 16:12:22 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> >
> > so we could set io apic routing only when enable device irq.
> >
> > also could make setup_IO_APIC_irqs and setup_ioapic_dest only handle
> > first ioapic...
> >
> > v2: remove one one not needed style change.
> > merge the patch only setup io_apic for acpi on in
> > setup_IO_APIC_irqs
> >
> > [ Impact: make mptable irq enable more like acpi is used, and
> > numa_irq_desc could get correct node when acpi=off ]
> >
> > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> >
> > ---
> > arch/x86/kernel/apic/io_apic.c | 148
> > ++++++++++++++++++++---------------------
> > arch/x86/pci/irq.c | 84 ++++++++--------------- 2
> > files changed, 103 insertions(+), 129 deletions(-)
>
> Jesse, did this patch have your Acked-by?

Yeah, both of them are fine with me. Ultimately you get to keep any
broken pieces from io_apic changes anyway, right? :)

Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/