Re: [RFC PATCH 3/3a] ptrace: add _ptrace_may_access()

From: Chris Wright
Date: Thu May 07 2009 - 04:59:09 EST


* Ingo Molnar (mingo@xxxxxxx) wrote:
> * Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > Agreed, but what about security_operations->ptrace_may_access ?
> > It has the same (bad) name, but returns the error code or 0 on
> > success.
>
> Bad code should generally be fixed, or in exceptional circumstances
> it can tolerated if it's pre-existing bad code, but it should never
> be propagated. It has not spread _that_ widely yet, and is isolated
> to the security subsystem:

And the security hooks tend to all follow the 0 success -ve ERR on error.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/