Re: [FOR REVIEW, PATCH 2/2] introduce "struct wait_opts" tosimplify do_wait() pathes

From: Roland McGrath
Date: Thu May 07 2009 - 03:49:45 EST


> I must admit, I do not agree. I feel the opposite. Yes we have 2 repeated
> assignment blocks, but there are not exactly equal, and imho the difference
> is more visible this way.

Ok, whatever.

> That said. This is not the technical issue, I can't "prove" I am right and
> of course I may be wrong. I think we should follow the "maintaner is always
> right" rule ;)
>
> I'll send this change as another cleanup on top of the new series.

Nah. The "he who wrote the last patch is the real maintainer" rule is
better. If the theoretical pitfalls I imagine ever materialize under our
feet, I'll tell everybody it was your fault (git will, anyway). ;-)


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/