Re: [PATCH 5/5] usb_debug: EXPERIMENTAL - poll hcd device to force writes

[Oliver Neukum]

Am Mittwoch, 6. Mai 2009 22:24:13 schrieb Alan Stern:
> On Wed, 6 May 2009, Oliver Neukum wrote:
> > Am Mittwoch, 6. Mai 2009 21:24:56 schrieb Alan Stern:
> > > On Wed, 6 May 2009, Oliver Neukum wrote:
> > >
> > > A little thought yielded the following algorithm.  It assumes there is
> > > a fixed set of URBs allocated, unlike what you have done.  Does it make
> >
> > No, it does not ;-) Your approach is more general than you think.
> > The only important constraint is that the number of URBs in flight
> > be limited. It doesn't matter when they are allocated.
>
> You're optimistically assuming that URB allocations will succeed.  I
> guess that's okay -- dropping characters when there's insufficient
> memory seems like a good thing to do.

I also have to assume submission works.

> What's the point of that "reserve_buffer" thing?  Why not just use the
> next URB's transfer buffer?

I am toying with the idea of reusing the last URB.

On a fundamental note, thinking about this in terms of numbers of URBs
is strictly speaking wrong. We need to limit data in flight. For efficiency
we should make buffers as large as possible within that limit.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/