Re: [patch 57/58] tracing: x86, mmiotrace: fix range test

[Steven Rostedt]

On Wed, 6 May 2009, Greg KH wrote:

> 2.6.29-stable review patch.  If anyone has any objections, please let us know.
> 
> ------------------
> 
> From: Stuart Bennett <stuart@xxxxxxxxxxxxxxx>
> 
> commit 33015c85995716d03f6293346cf05a1908b0fb9a upstream.
> 
> Matching on (addr == (p->addr + p->len)) causes problems when mappings
> are adjacent.
> 
> [ Impact: fix mmiotrace confusion on adjacent iomaps ]
> 
> Signed-off-by: Stuart Bennett <stuart@xxxxxxxxxxxxxxx>
> Acked-by: Pekka Paalanen <pq@xxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> LKML-Reference: <1240946271-7083-2-git-send-email-stuart@xxxxxxxxxxxxxxx>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve

> 
> ---
>  arch/x86/mm/kmmio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/mm/kmmio.c
> +++ b/arch/x86/mm/kmmio.c
> @@ -87,7 +87,7 @@ static struct kmmio_probe *get_kmmio_pro
>  {
>  	struct kmmio_probe *p;
>  	list_for_each_entry_rcu(p, &kmmio_probes, list) {
> -		if (addr >= p->addr && addr <= (p->addr + p->len))
> +		if (addr >= p->addr && addr < (p->addr + p->len))
>  			return p;
>  	}
>  	return NULL;
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/