Re: [PATCH, RFC] sputrace: use the generic event tracer

From: Christoph Hellwig
Date: Wed May 06 2009 - 07:04:01 EST


On Wed, May 06, 2009 at 12:57:48PM +0200, Ingo Molnar wrote:
> Nice! Needs also an Ack from PowerPC folks before we can do this.
> The cross section to other powerpc code seems to be rather low.

cbe-oss-dev is the Cell list.

> > -config SPU_TRACE
> > - tristate "SPU event tracing support"
> > - depends on SPU_FS && MARKERS
> > - help
> > - This option allows reading a trace of spu-related events through
> > - the sputrace file in procfs.
>
> I think we should keep this option around.

Why? trace_events that aren't enabled are extremly low overhead.
And most in the current tree are non-optional.

> > +# magic for the trace events
> > +CFLAGS_sched.o := -I$(src)
>
> Steve, i'm wondering whether this type of Makefile hackery (caused
> by modular tracepoints) could be eliminated ...

We would just have to include the header file with "" instead of <>.
But I remember Steve not liking this when we talked about it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/