Re: [PATCH] SLQB: Coding style cleanups

From: Pekka Enberg
Date: Tue May 05 2009 - 04:37:44 EST


Hi Nick,

On Tue, May 5, 2009 at 11:25 AM, Nick Piggin <npiggin@xxxxxxx> wrote:
>> @@ -59,7 +59,7 @@ static inline void struct_slqb_page_wrong_size(void)
>>  /*
>>   * slqb_min_order: minimum allocation order for slabs
>>   */
>> -static int slqb_min_order = 0;
>> +static int slqb_min_order;
>
> I actually like explicit zero initializers. I think it has been
> a long time since this actually saved any memory with gcc.
>
> Yes yes, I know that anybody who can "read C" will read the
> implicit zero initializer anyway... however I just think it is
> a stupid thing for checkpatch to warn against.

OK. I guess I can drop those hunks. But from coding style of point
view we don't really do explicit zero initializers in the core
kernel...

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/