Re: [PATCH] staging: &&/|| typo?

From: Andrew Morton
Date: Mon May 04 2009 - 19:06:18 EST


On Sat, 02 May 2009 22:46:47 +0200
Roel Kluin <roel.kluin@xxxxxxxxx> wrote:

> Subject: [PATCH] staging: &&/|| typo?

nit: if/when this driver gets moved out of staging/, it will still have
a commit titled "staging: &&/|| typo?" in its record.

That title will be pretty useless and meaningless for a driver which
isn't in staging!

So I'd suggest that in general, the "staging" information be included
inside [], so it gets tossed away as the patch is applied.

Also, the title is pretty bad in other ways - it doesn't identify what
part of the kernel is being changed. At least, not with sufficient
specificity.


So a better title would be, say,

[patch] [staging] wis-sony-tuner.c: fix &&/|| error


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/