Re: [PATCH] reiserfs: Expand i_mutex to enclose lookup_one_len

From: Andrew Morton
Date: Fri May 01 2009 - 16:02:00 EST


On Fri, 01 May 2009 12:11:12 -0400
Jeff Mahoney <jeffm@xxxxxxxx> wrote:

> 2.6.30-rc3 introduced some sanity checks in the VFS code to avoid NFS
> bugs by ensuring that lookup_one_len is always called under i_mutex.
>
> This patch expands the i_mutex locking to enclose lookup_one_len. This was
> always required, but not not enforced in the reiserfs code since it
> does locking around the xattr interactions with the xattr_sem.

cool, so this will fix all those backtraces people have been reporting
coming out of the reiserfs xattr code lately?

> This is obvious enough, but it survived an overnight 50 thread ACL test.

That sounds a bit pessimistic. I think I'll s/but/and/ ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/