Re: [PATCH 04/27] asm-generic: add legacy I/O header files

From: Arnd Bergmann
Date: Fri May 01 2009 - 08:53:55 EST


On Friday 01 May 2009, Russell King wrote:
> > > All of these are either PC-specific, or they don't actually care
> > > about the specific value. Most architectures just use the
> > > value from the IBM PC, so we might as well make that the generic
> > > default.
> >
> > ok. Let's move out from arch to generic location.
>
> That's only possible once the users have been fixed - otherwise the ARM
> stuff listed above _will_ break.

My idea was to just add a fallback of

#ifndef CLOCK_TICK_RATE
#define CLOCK_TICK_RATE 1193182
#endif

to include/linux/timex.h. Since al existing architectures already define
CLOCK_TICK_RATE as a macro, I don't see anything changing for them.

The only difference would be that all architectures that use the default
value can have an empty timex.h.

Am I missing something?

Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/