Re: [PATCH] mm/vmalloc.c: fix sparse warning

[Andrew Morton]

On Thu, 23 Apr 2009 21:35:57 +0100
Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> On Thu, Apr 23, 2009 at 01:23:58PM -0700, Andrew Morton wrote:
> > On Fri, 17 Apr 2009 20:55:06 -0400
> > "H Hartley Sweeten" <hartleys@xxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > > Fix sparse warning in mm/vmalloc.c.
> > > 
> > >   warning: symbol 'tmp' shadows an earlier one
> 
> Folks, could we please add to appropriate documentation (SubmittingPatches,
> perhaps) a bit about using descriptive subjects?

If everyone did that, my typing skillz would deteriorate.

> In general, "$TOOL warning in $FILE" says nothing useful.  In this case
> "Get rid of shadowed variable in mm/vmalloc.c:<function>" would be far
> more useful, with "found by sparse" _maybe_ showing up in the commit
> message more or less as a footnote.  Or even "shadowed variable in
> mm/vmalloc.c:<function>".

yup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/