Re: [KVM PATCH 2/3] eventfd: add a notifier mechanism

[Davide Libenzi]

On Thu, 23 Apr 2009, Gregory Haskins wrote:

> This allows synchronous notifications to register with the eventfd
> infrastructure.  Unlike traditional vfs based eventfd readers, notifiees
> do not implictly clear the counter on reception.  However, the clearing
> is primarily important to allowing threads to block waiting for events
> anyway, so its an acceptable trade-off since blocking doesn't apply to
> notifiers.

Do you really need to add a notifier? Eventfd already has a wait queue, 
and we support callback-based wakeups, so is there any reason we shouldn't 
use those and rely on the already existing wakeups?



- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/