Re: [PATCH] Eliminate thousands of warnings in WARN_ON with gcc 3.2build

From: Arjan van de Ven
Date: Thu Apr 23 2009 - 11:08:34 EST


Andi Kleen wrote:
On Thu, Apr 23, 2009 at 04:38:59PM +0200, Johannes Weiner wrote:
+void warn_slowpath_null(const char *file, int line)
+{
+ warn_slowpath_fmt(file, line, (const char *) { 0 });
+}
+EXPORT_SYMBOL(warn_slowpath_null);
I would WTF here without knowing the warning. Can you add a comment?

Otherwise, Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Ok version with comment.

Makes sense if we plan to keep gcc 3.2 supported; if we plan to drop it then we shouldn't bother.

Anyway

Acked-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/