Re: [PATCH 09/14] block: clean up request completion API

[Tejun Heo]

Christoph Hellwig wrote:
>> +EXPORT_SYMBOL_GPL(__blk_end_io);
> 
> That's really ugly code due to the locked argument.

Yeap, it's ugly.  Thought having one ugly path would be better than
duplicate implementations.

> Just make a helper for all code down to add_disk_randomness, and
> have two different functions call that and finish_request +/- the
> locking.

Alright, will change toward that direction.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/