RE: [RFC v2][PATCH 1/1] intel_txt: Intel(R) TXT and tboot kernelsupport

From: Cihula, Joseph
Date: Wed Apr 22 2009 - 16:47:44 EST


> From: Andi Kleen [mailto:andi@xxxxxxxxxxxxxx]
> Sent: Wednesday, April 22, 2009 1:40 PM
>
> On Wed, Apr 22, 2009 at 01:31:01PM -0700, Jeremy Fitzhardinge wrote:
> > Andi Kleen wrote:
> > >This means it explodes with paravirt, right? Do you have a check early
> > >for that?
> > >
> >
> > The tboot stuff should only be run on bare hardware; if there's
> > virtualization under the kernel, then TXT should be happening at that level.
>
> Yes I know, but still this should be enforced.

This code will only be executed if the tboot_shared page is found, which should not be the case if the kernel is running paravirtualized. But I'm planning to change it to just write_cr3() to be more consistent with other cases where we don't try to specifically exclude paravirt hooks.

Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/