RE: [PATCH] usb/core/hub.c: fix sparse warnings

From: H Hartley Sweeten
Date: Wed Apr 22 2009 - 16:03:22 EST


Fix sparse warning in drivers/usb/core/hub.c.

The following sparse warning is seen when building on ARM due
do the macro raw_local_irq_save():

warning: symbol 'temp' shadows an earlier one

Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

---

Patch is also attached in case of line-wrapping.


diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index be86ae3..c7a1a1d 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -457,13 +457,13 @@ static void hub_tt_kevent (struct work_struct
*work)

spin_lock_irqsave (&hub->tt.lock, flags);
while (--limit && !list_empty (&hub->tt.clear_list)) {
- struct list_head *temp;
+ struct list_head *next;
struct usb_tt_clear *clear;
struct usb_device *hdev = hub->hdev;
int status;

- temp = hub->tt.clear_list.next;
- clear = list_entry (temp, struct usb_tt_clear,
clear_list);
+ next = hub->tt.clear_list.next;
+ clear = list_entry (next, struct usb_tt_clear,
clear_list);
list_del (&clear->clear_list);

/* drop lock so HCD can concurrently report other TT
errors */

Attachment: usb_core_hub_c_sparse.patch
Description: usb_core_hub_c_sparse.patch