Re: [PATCH 18/22] Use allocation flags as an index to the zonewatermark

[Dave Hansen]

On Wed, 2009-04-22 at 14:53 +0100, Mel Gorman wrote:
>  struct zone {
>         /* Fields commonly accessed by the page allocator */
> -       unsigned long           pages_min, pages_low, pages_high;
> +       union {
> +               struct {
> +                       unsigned long   pages_min, pages_low, pages_high;
> +               };
> +               unsigned long pages_mark[3];
> +       };

Why the union?  It's a bit obfuscated for me.  Why not just have a
couple of these:

static inline unsigned long zone_pages_min(struct zone *zone)
{
	return zone->pages_mark[ALLOC_WMARK_MIN];
}

and s/zone->pages_min/zone_pages_min(zone)/

?

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/