Re: [PATCH 2.6.29.1 1/1] 8139too: fix HW initial flow

From: David Miller
Date: Wed Apr 22 2009 - 03:44:52 EST


From: Eric Dumazet <dada1@xxxxxxxxxxxxx>
Date: Tue, 21 Apr 2009 12:30:24 +0200

> Amos Kong a écrit :
>> ...
>> While ifconfig eth0 up kernel calls open() of 8139 driver(8139too.c).
>> In rtl8139_hw_start() of rtl8139_open(), 8139 driver enable RX before setting up the DMA
>> buffer address. In this interval where RX was enabled and DMA buffer address is not yet set
>> up, any incoming broadcast packet would be send to a strange physical address:
>> 0x003e8800 which is the default value of DMA buffer address.
>> Unfortunately, this address is used by Linux kernel. So kernel panics.
>> This patch fix it by setting up DMA buffer address before RX enabled and everything is fine
>> even under broadcast packets attack.
>>
>> Signed-off-by: Jonathan Lin <jon.lin@xxxxxxxxxx>
>> Signed-off-by: Amos Kong <jianjun@xxxxxxxxx>
>
> Signed-off-by: Eric Dumazet <dada1@xxxxxxxxxxxxx>
>
> Thanks Amos and Jonathan

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/