Re: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency

[Ingo Molnar]

* Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:

> On Wed, Apr 22 2009, Ingo Molnar wrote:
> > 
> > * Ingo Molnar <mingo@xxxxxxx> wrote:
> > 
> > > A last-minute build error slipped through:
> > >
> > >   In file included from fs/compat_ioctl.c:105:
> > >   include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ???mempool_t???
> > 
> > Caused by:
> > 
> >   1ba0c7d: fs/compat_ioctl: fix build when !BLOCK
> > 
> > fixed by the patch below. The build error itself triggers with 
> > !BLOCK
> 
> This fix is already queued up in the block tree, it just didn't 
> make -rc3.

ah, i see - it was posted two days ago:

  [PATCH 2/2] pktcdvd.h should include mempool.h

but the fix should have been queued up in the tree pushing the 
compat_ioctl.c change (Viro's). Could have been avoided by insisting 
on a fuller explanation in the changelog instead of just a "Fix this 
build error" line.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/