Re: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> Caused by:
> 
>   1ba0c7d: fs/compat_ioctl: fix build when !BLOCK
> 
> fixed by the patch below. The build error itself triggers with 
> !BLOCK
         [ ... so it is not very significant. ]

> pktcdvd.h relies on mempool_t but does not include mempool.h. This 
> worked until now accidentally: due to other headers including 
> mempool.h in compat_ioctl.c (and all other pktcdvd.h using sites). 
> But once the header file broke this implicit dependency got 
> uncovered and an uncleanliness turned into a build failure.
> 
> Add mempool.h to pktcdvd.h.

I think Sam's new include file self-sufficiency build checker could 
have caught it. (but there's a baseline to fix first: we have dozens 
and dozens of general purpose headers that do not build in a 
standalone .c file)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/