[PATCH] include/linux/pktcdvd.h: add mempool.h dependency

From: Ingo Molnar
Date: Wed Apr 22 2009 - 02:29:40 EST


A change to the order of header files in fs/compat_ioctl.c
unearthed a dormant header file dependency bug:

In file included from fs/compat_ioctl.c:105:
include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before âmempool_tâ

pktcdvd.h relies on mempool_t but does not include mempool.h.
This worked until now accidentally: due to other headers including
mempool.h in compat_ioctl.c (and all other pktcdvd.h using sites).
But once the header file broke this implicit dependency got
uncovered and an uncleanliness turned into a build failure.

Add mempool.h to pktcdvd.h.

[ Impact: fix build on !CONFIG_BLOCK ]

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
include/linux/pktcdvd.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
index 04b4d73..9cabc20 100644
--- a/include/linux/pktcdvd.h
+++ b/include/linux/pktcdvd.h
@@ -112,6 +112,7 @@ struct pkt_ctrl_command {
#include <linux/completion.h>
#include <linux/cdrom.h>
#include <linux/kobject.h>
+#include <linux/mempool.h>
#include <linux/sysfs.h>

/* default bio write queue congestion marks */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/