Re: [PATCH 2/2] tracing: use nowakeup version of commit for functionevent trace tests

[Steven Rostedt]

On Tue, 21 Apr 2009, Frederic Weisbecker wrote:

> On Mon, Apr 20, 2009 at 06:22:59PM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@xxxxxxxxxx>
> > 
> > The startup tests for the event tracer also runs with the function
> > tracer enabled. The "wakeup" version of the trace commit was used
> > which can grab spinlocks. If a task was preempted by an NMI
> > that called a function being traced, it could deadlock due to the
> > function tracer trying to grab the same lock.
> > 
> > Thanks to Frederic Weisbecker for pointing out where the bug was.
> > 
> > Reported-by: Ingo Molnar <mingo@xxxxxxx>
> > Reported-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > ---
> 
> 
> Aah, I was about to push my version, which was the same but with
> a more weird changelog :-)
> 

I was going to let you post it, but since I was the one to write the bug, 
and it was a one-liner, and I was hitting it myself, I decided to push it. 
Otherwise I might have seen your patch's signature section:

fixed-code-f*cked-up-by: Steven Rostedt

/me was reading the conversation on IRC ;-)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/