Re: [PATCH v3 1/1] ftrace, workqueuetrace: Make workqueuetracepoints use TRACE_EVENT macro

[KOSAKI Motohiro]

> * From: "KOSAKI Motohiro" <kosaki.motohiro@xxxxxxxxxxxxxx>
> >> Thanks for your suggest.
> >> I read distinction between workqueue and worklet.
> >> In my schedule, this patch is first step of our target, my image of steps is:
> >>   1: Move current workqueuetracepoints into TRACEEVENT (this patch)
> >>   2: Make workqueuetrace support per-worklet output (doing)
> >>   3: Add time information to workqueuetrace's worklet stat (need above new TRACEPOINT)
> >> 
> >> So, i prepared to add new worklet tracepoints in step3.
> >> What's your opinion?
> > 
> 
> Hello, Kosaki-san
> 
> > Zhao-san, Maintainer's easy reviewability is very important.
> I agree it.
> 
> > Can you switch 2 and 3 ?
> Sorry for my poor English.
> I means 2 is to add worklet stat, 3 is to add more information to worklet stat,
> 3 is based on 2, switch 2 and 3 means merge 2 and 3.

OK.

thus, I recoomend to pending 2 and 3. and change 1 as Ingo suggested.
if not, reviewer might forgot this thread.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/