Re: [rtc-linux] [PATCH/RFC 15/16] rtc: Add an RTC driver for the Ricoh RP5C01

[Geert Uytterhoeven]

Hi Alessandro,

On Sat, Apr 18, 2009 at 23:55, Alessandro Zummo
<alessandro.zummo@xxxxxxxxxxxx> wrote:
> On Sat, 18 Apr 2009 20:52:23 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> ÂHi Geert, thanks for your contributions. Comments below.
>
> ÂMissing patch description.

git-am is happy with the one-line summary in the subject:-line, and
there's not much more to say.

>> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> Cc: rtc-linux@xxxxxxxxxxxxxxxx
>> ---
>> Âdrivers/rtc/Kconfig   Â|  10 ++
>> Âdrivers/rtc/Makefile   |  Â1 +
>> Âdrivers/rtc/rtc-rp5c01.c | Â239 ++++++++++++++++++++++++++++++++++++++++++++++
>> Â3 files changed, 250 insertions(+), 0 deletions(-)
>> Âcreate mode 100644 drivers/rtc/rtc-rp5c01.c
>>
>> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
>> index a0f6297..150fe43 100644
>> --- a/drivers/rtc/Kconfig
>> +++ b/drivers/rtc/Kconfig
>> @@ -535,6 +535,16 @@ config RTC_DRV_MSM6242
>> Â Â Â Â This driver can also be built as a module. If so, the module
>> Â Â Â Â will be called rtc-msm6242.
>>
>> +config RTC_DRV_RP5C01
>> + Â Â tristate "Ricoh RP5C01"
>> + Â Â help
>> + Â Â Â If you say yes here you get support for the Ricoh RP5C01
>> + Â Â Â timekeeping chip. It is used in some Amiga models (e.g. A3000
>> + Â Â Â and A4000).
>> +
>> + Â Â Â This driver can also be built as a module. If so, the module
>> + Â Â Â will be called rtc-rp5c01.
>> +
>> Âcomment "on-CPU RTC drivers"
>>
>> Âconfig RTC_DRV_OMAP
>> diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
>> index c70418b..6176a8a 100644
>> --- a/drivers/rtc/Makefile
>> +++ b/drivers/rtc/Makefile
>> @@ -77,4 +77,5 @@ obj-$(CONFIG_RTC_DRV_WM8350) Â Â Â Â+= rtc-wm8350.o
>> Âobj-$(CONFIG_RTC_DRV_X1205) Â+= rtc-x1205.o
>> Âobj-$(CONFIG_RTC_DRV_PCF50633) Â Â Â += rtc-pcf50633.o
>> Âobj-$(CONFIG_RTC_DRV_MSM6242) Â Â Â Â+= rtc-msm6242.o
>> +obj-$(CONFIG_RTC_DRV_RP5C01) += rtc-rp5c01.o
>> Âobj-$(CONFIG_RTC_DRV_PS3) Â Â+= rtc-ps3.o
>
> Âalphabetic order please

Will do.

>> +static const struct rtc_class_ops rp5c01_rtc_ops = {
>> +   .read_time   Â= rp5c01_read_time,
>> +   .set_time    = rp5c01_set_time,
>> +   .set_mmss    = rp5c01_set_mmss,
>> +};
>
> Âplease implement either set_time or set_mmss, not both.
> ÂI don't know the chip but I suspect set_time is the one you need.

OK, I will remove .set_mmss. Got to confused by looking into how
everything is used...
BTW, the only remaining users of rtc_set_mmss() seem to be
arch/sparc/kernel/time_{32,64}.c?

>> +MODULE_AUTHOR("Geert Uytterhoeven");
>
> Âit would be fine to have your email here.

Will do.

OK, if I take the result (for both rtc-rp5c01 and rtc-msm6242) through
the m68k tree?
Thanks!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/