Re: [PATCH] usb driver for intellon based PLC like devolo dlan duo

From: David Miller
Date: Sun Apr 19 2009 - 00:15:26 EST


From: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
Date: Sat, 18 Apr 2009 21:54:11 +0200 (CEST)

> If you are working with that file and see a call to reg_write() you
> know where to look for it.

I would never use such a generic name for a driver local routine.

For example, in the tg3 driver we use "tr32()" and "tw32()" so that
at least some inkling of the driver name, even if it is just one
character, prefixes the name.

This extends to other driver's I've written. The niu driver thus
uses "tr64()" and "nw64()".

This is just common sense as far as I'm concerned. It is just
as straight forward as not using variable names like 'foo'.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/