Re: [PATCH] arm: use include/gen for mach-types.h

From: Al Viro
Date: Sat Apr 18 2009 - 23:49:46 EST


On Sat, Apr 18, 2009 at 12:28:51PM -0700, Linus Torvalds wrote:
>
>
> On Sat, 18 Apr 2009, Sam Ravnborg wrote:
> >
> > diff --git a/include/gen/.gitignore b/include/gen/.gitignore
> > new file mode 100644
> > index 0000000..1e809fd
> > --- /dev/null
> > +++ b/include/gen/.gitignore
> > @@ -0,0 +1,2 @@
> > +# mach-types.h is used by arm
> > +mach-types.h
>
> I think this is bad.
>
> The whole point of having 'include/gen' should be that _all_ files in that
> directory should be generated. So it should be include/.gitignore that
> just contains the pattern "gen/" and that's it.

Or .gitignore in top-level, same as for include/config
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/