Re: [PATCH] tracing: fix file mode of trace and README

[Li Zefan]

>> -	trace_create_file("current_tracer", 0444, d_tracer,
>> +	trace_create_file("current_tracer", 0644, d_tracer,
>>  			&global_trace, &set_tracer_fops);
> 
> 
> 
> Oh!
> I wonder how much time we ran with this false permission.
> It clearly shows a bug in debugfs permission (or something
> near this this layer), we have be running with this file
> for a while and I've never seen any issue while writing into it.
> 
> And we have seen several patches with 0444 permissions for the
> tracing tree containing writeable files, showing that the authors
> ran them whithout problems.
> 

It's not a bug in debugfs or vfs. It's just because root can
do anything. ;)

> Adding Greg in Cc.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/