Re: [PATCH] tracing: add #include <linux/delay.h> to fix buildfailure in test_work()

From: Ingo Molnar
Date: Thu Apr 16 2009 - 20:31:26 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

>
>
> On Thu, 16 Apr 2009, Ingo Molnar wrote:
> >
> > ------------------------>
> > >From 63c14122a54c26122ccdbe596123f8e2b75c3116 Mon Sep 17 00:00:00 2001
> > From: Ingo Molnar <mingo@xxxxxxx>
> > Date: Thu, 16 Apr 2009 10:26:51 +0200
> > Subject: [PATCH] tracing: add #include <linux/delay.h> to fix build failure in test_work()
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=utf-8
> > Content-Transfer-Encoding: 8bit
> >
> > This build failure occured on a few rare configs:
> >
> > kernel/trace/trace_events.c: In function ?test_work?:
> > kernel/trace/trace_events.c:975: error: implicit declaration of function ?udelay?
> > kernel/trace/trace_events.c:980: error: implicit declaration of function ?msleep?
> >
> > delay.h is included in way too many other headers, hiding cases
> > where new usage is added without header inclusion.
> >
> > Impact: build fix
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
>
> Thanks Ingo!
>
> I don't see this change in tip, do you want me to apply it in my tree?

It's pushed out now.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/